On Thu, 30 Jun 2011, Johannes Schlüter wrote: > On Thu, 2011-06-30 at 07:08 +0200, David Zülke wrote: > > On 29.06.2011, at 01:19, Johannes Schlüter wrote: > > > > > On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote: > > >> - Colours messages according to their response code (success=green, > > >> client error=yellow, server error=red) > > > > > > I would prefer if this would be an ini option (if (cli_web_server.color > > > && isatty) color = true) default can be on, but I've seen cases where > > > such magic failed and created hard-to use results (due to control > > > sequences in log files or such). > > > > The code could detect if it's outputting to a TTY or not and only use > > color codes if the output isn't redirected somewhere else. > > It *is* checking this. And I showed an example (script(1)) where the > environment pretends to be a TTY and isn't. My suggestion was to add an > ini option in addition to the check.
I'm fine with that, but let's leave it set to 1 by default? People with complex requirements can then turn it off if they want to. regards, Derick
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
