On Wed, 2011-06-29 at 11:45 +0100, Derick Rethans wrote:
> That's why the patch first checks whether stdout is actually a tty, so 
> your log file will not have ansi control characters.

While that check is not always the best/good thing. For instance if
you're using script(1) to log a terminal session you will end up with a
log file with control sequences.

Script started on June 29, 2011 12:59:59 PM CEST
$ cat test.c
#include <unistd.h>

int main() {
        printf("%i\n", isatty(STDOUT_FILENO));
        return 0;
}
       
$ gcc -otest test.c
$ ./test
1
$ exit
script done on June 29, 2011 01:02:11 PM CEST

And then there are people using "strange" backgrounds or have trouble
identifying specific colors - so I think it should be made optional.

johannes


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to