hi, I like the feature, it is a nice and useful one.
However nobody ever posted anything on internals about it. The differences between the implementation and the RFC as well as the questions raised by this addition show that it would be better to discuss prior to commit. But as it is in trunk, that's less a problem, that's why trunk exists: a development tree. I would still like to see some kind of discussions about it. I would prefer a simple __toJson for example (yes, that's magic) :). Cheers, On Thu, May 6, 2010 at 7:41 PM, Guilherme Blanco <guilhermebla...@gmail.com> wrote: > Hi guys, > > > I'd like to thank you for this implementation. > > @Pierre: There is a RFC I wrote: http://wiki.php.net/rfc/jsonable > > I'd suggest to rather be JSONSerializable or be Jsonable. > > JSON is an acronym, the same as PDO. We don't have interface for Pdo, > but for PDO. > So we should keep consistency. > > > Cheers, > > > On Thu, May 6, 2010 at 8:37 AM, Pierre Joye <pierre....@gmail.com> wrote: >> On Thu, May 6, 2010 at 12:59 PM, Hannes Magnusson >> <hannes.magnus...@gmail.com> wrote: >>> On Thu, May 6, 2010 at 00:48, Sara Golemon <poll...@php.net> wrote: >>>> pollita Wed, 05 May 2010 22:48:14 +0000 >>>> >>>> Revision: http://svn.php.net/viewvc?view=revision&revision=299037 >>>> >>>> Log: >>>> Add JSON_Serializable interface >>> >>> Slight bikeshedding.. but we don't use underscore for >>> interface/classnames... >> >> And I would go with JsonSerializable. >> >> However, where does it come from? Does it have to be an interface or >> why not using __toJson? I must have lived under a rock as I don't see >> any proposal either, be RFC or internals. >> >> Cheers, >> -- >> Pierre >> >> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > > > -- > Guilherme Blanco - Web Developer > CBC - Certified Bindows Consultant > Cell Phone: +55 (16) 9215-8480 > MSN: guilhermebla...@hotmail.com > URL: http://blog.bisna.com > São Paulo - SP/Brazil > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
