On Wed, Sep 09, 2009 at 10:46:53AM +0300, Jani Taskinen wrote: > Yeah, NO THANKS. We have enough of unmaintained code already. Since > you want this fpm thing into upstream PHP releases, why not make the > changes into libevent go upstream as well and then reconsider > bundling, merging, etc.
that seems a natural corollary, yes. that or remove the need for making
the local modifications in the first place. i'm not at all familiar
with the fpm project so wasn't aware of this until it was brought up, and
i don't know the specifics of how/why the library has been modified.
i should also point out that it's not exactly that *I* want this to be
included in php... all i know is that as a general rule when someone
comes along saying "hey can you apply this huge patch for a new feature",
i'm inclined to first point them at the upstream developers to try to
get it sorted out there.
this allows for a certain level of code review and the chance to get an
idea of what you think of the feature, as well as potentially benefitting
the entire php user base (if you take it) vs. the limited one of those
using debian-derived php packages (if we take it). and if you don't
like/want the patch, it would be good to know the reasons as it'd help
us decide whether or not we want it too.
sean
--
signature.asc
Description: Digital signature
