On 09/09/2009 08:55 AM, sean finney wrote:
On Wed, Sep 09, 2009 at 03:42:44AM +0100, dreamcat four wrote:
Not sure about bundling libevent though - does it have to be bundled?
Don't know. Libevent is frozen in there and a couple of files were
modified with references back into the fpm headers.
The Libevent was updated recently anyway, so its a pretty recent version.
just FYI this will also be problematic. as some of the other php devs
are probably well aware (hi pierre!), we have a pretty strict policy
against using embedded libraries, even more so for embedded libraries
that have been locally modified.
Yeah, NO THANKS. We have enough of unmaintained code already. Since you
want this fpm thing into upstream PHP releases, why not make the changes
into libevent go upstream as well and then reconsider bundling, merging,
etc.
--Jani
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
