Hi, On Tue, 2007-12-18 at 09:57 -0800, Andi Gutmans wrote: > Uhm I meant 5.3. > I guess we can commit it but as you know, reverting this kind of stuff > later is a headache people don't like doing. With this patch it's not > too bad because besides the macros which are committed already it's mostly > isolated.
So can anybody do the commit then? Thanks. > Only enough testing by people on the list will be able to give us > additional information re: to the merits of this patch and how we > should handle it. My hope people find it stable with negligible > performance impact so that we can always keep it compiled in by default. Right, and having it in CVS really helps having many people testing it in different environments. johannes > Andi > > > -----Original Message----- > > From: Derick Rethans [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, December 18, 2007 9:20 AM > > To: Andi Gutmans > > Cc: Dmitry Stogov; PHP Developers Mailing List > > Subject: RE: [PHP-DEV] Garbage collector patch > > > > On Tue, 18 Dec 2007, Andi Gutmans wrote: > > > > > Derick Rethans wrote: > > > > > > > > Maybe we just should put it in cvs then? Then we won't have this > > issue > > > > and other people can test it more easily as well. > > > > > > The only problem with that is what if people get bad > > > benchmarks/results and we want to pull it out? It kind of defeats the > > > purpose to do this in a more structured way. Want us to commit it to > > a > > > branch? PHP 5.2.x? > > > > Neither of those solve the merging issues, so no, not to a branch or > > 5.2. It should just go to HEAD and PHP_5_3. *If* it seems to be really > > bad, we can always revert it later. > > > > regards, > > Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
