Making sure it is ifdef'ed nicely would let us leave it in CVS until we get it right and if it causes problems for some people they have a way to build PHP without it. And yes, that means their build won't be binary compatible, which is fine and no different from them trying to revert the patch themselves.
-Rasmus Ilia Alshanetsky wrote: > Putting it into CVS into a good idea, but lets create a revert point via > a tag, so we can always easily "undo" the patch if need be. > > > On 18-Dec-07, at 10:05 AM, Derick Rethans wrote: > >> On Tue, 18 Dec 2007, Dmitry Stogov wrote: >> >>> Derick Rethans wrote: >>>> On Mon, 17 Dec 2007, Dmitry Stogov wrote: >>>> >>>>> Didn't I send it to you? >>>> >>>> Maybe, maybe not :) I couldn't find it atleast. >>>> I just tried to apply this to PHP 5.3, but it gives lots of failed >>>> chucks... >>>> Are you sure this is the one against 5.3? >>>> >>> Probably I've changed ZE after the patch was done :( >>> I'll rebuild it, but not today. >> >> Maybe we just should put it in cvs then? Then we won't have this issue >> and other people can test it more easily as well. >> >> regards, >> Derick >> >> -- >> Derick Rethans >> http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > Ilia Alshanetsky > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
