Rasmus Lerdorf wrote:
That's fine, and you shouldn't care, I agree. I argued much the same
point just yesterday in a chat with Ilia. You do however seem to be
glossing over the fact that this new check can be very helpful. Take
this case:
sort(array(3,2,1));
Or any other example where the function in question has no other purpose
than to modify its argument. When you pass in something to a function
like this which has no permanent storage, chances are pretty high that
this is a bug in the code and you probably want to know about that. So
I really don't see this as such a black and white case. I am all for
making this a non-fatal error in all cases to allow scripts to keep
working, but I don't buy the argument that just because we didn't check
for this before we are not allowed to check for it now when it can find
valid bugs like this.
-Rasmus
No you don't understand me. While I disagree with the way the bug was
solved, and the inconsistancies it seems to introduce, I don't have a
problem with the error message in PHP5. PHP4 however should be stable
and unchanging except for bug fixes, and maybe additions, never
removals. Scripts that worked error free before on 4.3 are now spewing
them out in 4.4. I don't believe programmers should have to deal with
that sort of problem unless they make a major version upgrade.
Anyway, this is getting way off from my original post which was a
critisism of the handling of this whole situation and the treatment of
the community. I don't feel I am qualified to argue this particular
issue because I have never encountered it. I don't use references unless
I absolutely have to.
I believe all of this could of been avoided with careful PR. Now you
need some major PR to repair the damage.
Leigh :)
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
