Yep, will do.
I dont want to pretend that this change should open the flood gates for radical changes. However there are still a few minor points beyond the bindParam() that may need minor adjustments. Some of them can be added later of course ..
1) DSN http://oss.backendmedia.com/index.php?area=PDO&page=DSN
It would be nice to be able as an array and for the string format it would be nice to also have the option of using the established PEAR DSN format
2) exec() http://oss.backendmedia.com/index.php?area=PDO&page=exec
It may be nice to have a simple one shot prepared query to be able to do a prepare/execute in one call.
3) setAttribute/getAttribute http://oss.backendmedia.com/index.php?area=PDO&page=setAttribute
Some of the "attributes" are actually more like options that can be defined by the user. Others are defined by the client and yet others are defined by the server and cannot be changed by the user. I think atleast the user definable options should be moved to a separate setOption/getOption set of methods.
4) minor API stuff in the fetch methods
I think it would be clearer to call the fetch() method fetchRow() because that is what the method does. I also dont think we should default to PDO_FETCH_BOTH. It may also be a nice touch towards PEAR::[M]DB[2] to rename the fetchSingle() method to fetchOne(). Its also more clearer since fetchSingle() might as well imply a single row. Fetching a single row should probably be handled by a fetchCol() method.
regards, Lukas
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
