Wez Furlong wrote:
Yep, will do.
I dont want to pretend that this change should open the flood gates for radical changes. However there are still a few minor points beyond the bindParam() that may need minor adjustments. Some of them can be added later of course ..
I also noticed that bindParam() and bindColumn() are 1-indexed, which will raise inconviniences with people using arrays for example to stored the numeric indexes, similar in how having to add the ":" was a problem for people using arrays to store the string parameters.
Beyond that rowCount() is more traditionally affectedRows() etc which needlessly break with existing method names in both php core extensions and PEAR packages. I would really like to avoid adding even more names and instead sticking with picking names from this already fairly vast name pool. It might even be a good idea to pick from the names most commonly used. I have attached a reference to the document I once drafted for this exact purpose [1]. I dont know where the names in PDO originate from. They dont seem to match the current oci8 extension (I first assumed these originated from the fact that alot of the API matured during your work on the oracle driver), but this does not seem to be the case.
I know I am getting on your nerves Wez, but I really think that the API should at this stage still be open to optimizing the API. While its no longer beta I still think its a bit premature for comments like these:
"There are releases on pecl.php.net, and there are (a few) people running these in production. In addition, it's been advertised as working this way for over a year."
How about sitting down together at php|tropics (I didnt plan on going to a'dam .. dunno about you Wez .. but if necessary I will travel to a'dam for a day) and simply going through each of the methods one by one. Looking at what kind of methods names we currently are using for the same or similar things in any of the current projects on php.net and make any adjustments then?
[1] http://marc.theaimsgroup.com/?l=php-dev&m=106440782305693&w=2
regards, Lukas
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
