Hi Tim, On Sun, Jul 19, 2026 at 8:35 PM Tim Düsterhus <[email protected]> wrote:
> 1. There are some rendering issues / broken markup that make to me > greatly reduce the readability. One example would be “for example > ``Gd\Png``, ``Gd\Jpeg``, ``Gd\Webp``, and ``Gd\Bmp``” where the > double-backticks are emitted as-is and not interpreted. I will fix those :) > I recommend using the `<php>…</php>` tags around all inline PHP code > (including class names), it will come with basic syntax highlighting. ah, I will update it, and maybe the syntax page while at it. > 2. The proposed exceptions are in violation of the Throwable policy that > you can find at: > https://github.com/php/policies/blob/main/coding-standards-and-naming.rst#throwables. > In particular you need a “GdException extends \Exception” base > exception, and must never inherit from RuntimeException. That was in the question,I was not sure. I will update. > 4. The named constructors for GdImage should probably be named > consistently with Dom\Document: > https://github.com/php/php-src/blob/0fdd7ab9f1382b58b6837be138a1a25644495485/ext/dom/php_dom.stub.php#L1675-L1679 I will check and update accordingly. > > Discussions open for 14 days, until 2026/08/01. > > Just 14 days is likely a little short for an RFC of this size. But there > is no need to rush it: The window for PHP 8.6 has already closed for all > new RFCs or RFCs with a major change. No, it is not closed. Features freeze is not here yet. And if the PR review process was not taking so long to get approved there and not only here, that RFC would have been sent 3 weeks ago :). Something I am looking at to see what could be improved. Current default reviewers do an amazing job. It is simply too much cognitive weight for all the areas and the amount of PRs. Other topic. Aslo, everything new is added on top. So as all RFCs, during the discussions we can tweak the details if needed. And the implementation is already almost complete. Cheers, -- Pierre @pierrejoye
