On Wednesday, 9 October 2024 at 21:16, Eric Norris <eric.t.nor...@gmail.com> wrote:
> Hello all, > > After receiving some feedback about > https://github.com/php/php-src/pull/15603, I'm formally proposing an > RFC to add persistent curl share handles here: > https://wiki.php.net/rfc/curl_share_persistence > > Thanks to those who have provided feedback so far! Of note: the > implementation introduces a global variable to the curl extension via > ZEND_BEGIN_MODULE_GLOBALS; this appears preferred over > EG(persistent_list). Should the implementation stick with the module > global, or should it go back to EG(persistent_list) until we've > created a formal non-resource API (in another RFC)? > > I'd like to keep the future of persistent resources out of scope for > the decision on whether to add curl share handle persistence to PHP, > but it is worth deciding what form the persistence takes for now. I have voted against the RFC as it lacks details and there seems to have been no analysis on what sort of issues this can cause. This has been pointed out by Tim already, and this should have been caught earlier, but I don't know if it just me, but it seems your email kinda went into some void and got unnoticed. Persistent handlers don't really fit PHP's model, and are practically untestable from a PHPT test perspective as far as I know (at least I have never seen any proper tests for the existing ones, but I am happy to be corrected). As such I am very reluctant to adding more of these things to the language, especially when this seems to just have been hacked together quickly, we still have at least 7 months before feature freeze and I would prefer to actually be done properly. Especially that it is always easier to add new features than to deprecate and remove bad ones (which is kinda backwards but not relevant to this discussion). Best regards, Gina P. Banyard
