On Wed, Oct 23, 2024, at 21:20, Eric Norris wrote: > Apologies Rob, I don't seem to be receiving individual emails from the > mailing list, so I'll have to respond to my own email here. I've > changed my subscription to receive all emails so hopefully I'll be > able to respond directly to future emails. > > > It might be a good idea to get a “strong opinion” on the signature of > > curl_share_init. > > I think you are right. I've chatted with Rasmus and we both agree that > changing the signature of curl_share_init is preferable to adding a > new function - it's more in line with how we do persistence elsewhere. > I'll update the RFC to remove the signature question. > > Were you also suggesting that I shouldn't ask a question about the > implementation regarding using EG(persistent_list) vs. a module > global? I'm torn; I agree that it is an implementation detail but I > was hoping to actually get wider input since it generated discussion > in my pull request. Since no one responded here I felt like it'd be a > lightweight way to get feedback on what people felt, but the lack of > response probably means that people don't feel strongly enough about > it. > > That said, after reflecting I think I would agree that it is > unnecessary to add this as a question, and I'll continue with the > implementation as-is in the PR. If people would like to send feedback > on using EG(persistent_list) instead, feel free to do so here or in > the PR. > > > Also, it might be worth saying the “next minor version of PHP” just in case > > there isn’t an 8.5 and goes to 9.0. > > Makes sense to me, I'll make this change. >
For what it is worth, I think you should go for the EG(persistent_list) method. Over on FrankenPHP, we are looking into some improvements to TSRM (so that Go and PHP can share some of the same locks, among other things) and EG uses TSRM while I think a module global would not. — Rob
