At 19:29 14/09/2004, Derick Rethans wrote:
> And yes, there is no doubt that this patch can critically alter the way
> PHP works and has the potential to break all sorts of stuff.  Anything
> that relies on PHP knowing the full path will break.  I had to fix both
> xdebug and APC, for example.  At the same time, enough people have asked
> me about it that it probably should be more accessible.

I agree, there are a lot of people who might benefit from it (and do
already!) and thus the reason for me to put it into something usable for
everybody so that 1) rasmus doesn't have to maintain the patch anymore
and 2) users don't have to keep updating their PHP whenever they upgrade
PHP.

I don't disagree that it can be useful. But such a feature should not come bundled as an option in PHP. The Right(tm) solution here is to provide the realpath cache, which will speed performance up without breaking compatibility, and hopefully we'll have that one real soon now. We can maybe look into backporting it to PHP 4 as an optional feature (just to make sure we don't break apps in case it's buggy).


Adding this patch as an option goes against everything that we've been trying to do in the last few years. This useful patch should be made available so that those who really need it can find it, but it should come up with a huge disclaimer, and it should not be trivial for users to enable it in the form of --enable-foo. I see the fact that people have to invest some work in using it as a good thing, since if a lot of people start using it, it can become a very big headache very quickly.

Zeev

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to