At 10:52 AM 9/14/2004 -0700, Rasmus Lerdorf wrote:
The patch doesn't just address realpath though.  We have a number of other
redundant/non-essential syscalls in the streams code, for example.  And
the realpath cache is still heavier than not worrying about the full path
at all.

Can you describe the other non-essential syscalls? I want to be sure we really can't cover those (probably some of them we can't).
As far as the realpath patch goes (which is probably the biggest problem), I think that if we have the realpath cache in CVS that part of your patch won't be needed because I think the additional few K of memory wouldn't make it any noticeably slower even on loaded systems. So let me put some gas on that patch and that would allow to at least cut down your patch a bit.


I do agree that however people get this patch, they need to understand
that they are not running standard PHP and it is likely to break many
things.  At the same time, having it in CVS and maintainable by others and
having a single known version of this would help the people who use it and
the people who want to tweak their extensions to support it.

Perhaps we need a central php.net hosted and CVS-backed place for
unsupported patches and nasty hacks like this?  Useful ideas that are
applicable to a wider audience do often grow out of some of these crazy
hacks.

Yes, I definitely think that is needed because there have been some patches floating around which probably shouldn't be in the core distribution but should be out there with big disclaimers for people who want to use them.
I know Steph was working on something like that because she also felt there needs to be easier access to such patches (and I agree). I'm not sure where that project is at right now.


Andi

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to