On 2023/01/20 16:00, "Christoph M. Becker" <cmbecke...@gmx.de> wrote: > I'm afraid the worst that can actually happen is that this breaks a lot > of PHP extensions, SAPIs, etc.
True, I meant out-of-tree code, too. I will add some extra care to ensure compatibility even with "bad" extensions, by re-adding removed #include lines to php[_compat].h, as suggested by Jakub. I agree that any breakages of out-of-tree code could (or should) be regarded a regression that needs to be fixed, no matter how bad that code is. I'm ready to take responsibility for eventual breakages and do my best to submit fixes quickly. > We do not know how many there are, and we cannot even check all PECL > extensions for practical reasons. It would be helpful to add a few selected extensions to the CI, so unintended API regressions are detected as early as possible. > So we need to be careful here. Understood, I will! Max -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
