As commented yesterday on one of the PRs, I strongly agree with the cleanups. Our code has implicit dependencies and if you reorder the includes in the same file, you can break builds. That shouldn't ever happen.
I also agree that dtrace breaking is a failure of CI and testing, not necessarily the patch (I haven't reviewed that PR carefully, maybe there was some carelessness but if it's not tested, it's hard to blame anyone). Lastly, I do not care for the comments which explain why a header is included. My experience is that these comments bitrot quite quickly. Overall, I hope we can resume this effort. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
