I hadn't even thought about that but it should give the desired results. Can the error message be modified slightly to indicate that it is running under ze1 compat in zend_execute.c? Right now it just says: "Trying to clone an uncloneable object of class %s", which is fine in most cases, but at least indicating that the clone was an attempt due to ze1 compat would be more helpful and hopefully reduce bug reports.
Well again, I'd like to keep the core part without too many branches. So if you want to change the message, then best to implement the clone handler for ze1.compatibility_mode and throw an E_ERROR there with the message you think is suitable.
If all works well, is it ok to make this change in the 5_0 branch as well as this will be a minor BC break and rather do this sooner than later (and I mean minor as they dont work correctly anyways under compat mode), but now will produce E_ERROR.
I think it makes sense.
The following ext are the ones I would like to change: dom simplexml (right now it works fine as long as it is read only, but once someone tries to change the xml, it doesn't work correctly) xsl - remove clone support completely as there is no copy function for an xslt stylesheet anyways
Andi
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
