I hadn't even thought about that but it should give the desired results. Can the error message be modified slightly to indicate that it is running under ze1 compat in zend_execute.c? Right now it just says: "Trying to clone an uncloneable object of class %s", which is fine in most cases, but at least indicating that the clone was an attempt due to ze1 compat would be more helpful and hopefully reduce bug reports.
If all works well, is it ok to make this change in the 5_0 branch as well as this will be a minor BC break and rather do this sooner than later (and I mean minor as they dont work correctly anyways under compat mode), but now will produce E_ERROR. The following ext are the ones I would like to change: dom simplexml (right now it works fine as long as it is read only, but once someone tries to change the xml, it doesn't work correctly) xsl - remove clone support completely as there is no copy function for an xslt stylesheet anyways Rob From: Andi Gutmans > I don't see why you should remove the clone functionality of these > extensions if they work with standard PHP 5? The fact that it doesn't work > with compatibility mode isn't a good enough reason in my opinion. That > said, what you could do is have two sets of handlers arrays, one with the > clone and one with NULL. You can then check ze1.compatibilit_mode in the > extension and use the relevant handlers array. > What do you think? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
