On Fri, Aug 26, 2022 at 11:53 AM Christian Schneider <cschn...@cschneid.com> wrote:
> Am 26.08.2022 um 18:28 schrieb Sara Golemon <poll...@php.net>: > > What I can see is two noble, but conflicting ideals: > > 1/ sort() and ksort() should be consistent about their sorting > algorithms. > > I think we can all agree about that in the ideal case, at least. > > 2/ Behavior within a minor release should be self-consistent and > > predictable. > > > > Given the above, my initial inclination is to err on the side of > > conservatism for 8.0.x at the least (we're nearly at the end of our > primary > > bug-fix cycle anyway) by reverting the fix on our branch. > > For 8.1, I think we have a more difficult decision to make with over a > year > > of bug-fix releases to go, and I might be swayed to keep the fix around > > there. > > I agree with the description of the ideals but I'm not sure why you think > the resolution should be different of 8.0 than 8.1. > > We already transitioned our existing code base from 8.0 to 8.1, including > testing for changes due to the way numeric string are handled. I think it > is reasonable to adapt it for 8.2 (where another round of breaking changes > will have to be tested anyway) but I would not expect to having to do this > for a bug-fix release 8.1.x. > > That's why I'd rather have this change postponed to 8.2 (which is not that > far off anyway). > > Honestly, I vacillated on this one for awhile, having started from a "we should really revert on 8.1 as well". I flipped when I decided that the breakage potential was honestly very small. That said, no real complaints either way. -Sara
