On Tue, Jul 6, 2021 at 4:38 PM Go Kudo <zeriyo...@gmail.com> wrote: > > 1st > > This is to avoid conflicts with the implementation in ext/standard. I don't > want to do it this way either, but I have to do it this way. > Since random in ext/standard does not use namespaces, I would like to > change the ext/standard side. >
To clarify, are you referring to the php_random.h header in ext/standard? I agree with Remi that the extension should be in ext/random, not ext/random_ext. We can rename the ext/standard header. Alternatively, you could also use ext/rng, with names RNG\Random, RNG\NumberGenerator\XorShift128Plus etc. Regards, Nikita > > 2nd > > Although it goes back quite a long time, this implementation was originally > based on an extension I submitted to PECL. > > https://pecl.php.net/package/orng > > After I posted this to PECL, I found that an object scope RNG had been > proposed in the past in the Internals ML, and there was positive feedback > about it. > > https://externals.io/message/112525 > > However, the proposal never actually took place. This RFC is a realization > of that proposal. > > Is that what you asked? > > Regards, > Go Kudo > > 2021年7月6日(火) 22:46 Remi Collet <r...@php.net>: > > > Le 26/06/2021 à 02:39, Go Kudo a écrit : > > > Hello Internals. > > > > > > RFC has been reorganized for finalization. > > > > > > https://wiki.php.net/rfc/rng_extension > > > > 1st I dislike the name "random_ext", why this "_ext" part ? > > > > 2nd why not following the standard process ? > > > > 1/ publish on pecl > > 2/ merge in php-src if enough success and good feedback > > > > > > Remi > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: https://www.php.net/unsub.php > > > > >
