On Wed, 7 Jul 2021 at 10:23 am, Nikita Popov <nikita....@gmail.com> wrote:
> The RFC indicates that the impact is minor, but I believe those > measurements were made with the original version of the RFC, which did not > try to distinguish literal and non-literal interned strings Hi Nikita, The performance test results in the RFC are based on the latest version, updated on Monday (before the vote started), Máté Kocsis did these tests independently to ensure there was no bias from me (my own tests were roughly the same). Joe Watkins would be better placed to explain the details of the implementation. We have always tried to keep the implementation as simple as possible, but there were concerns that certain optimisations by the compiler would make certain strings appear as literals, not in an unsafe way, but in a way that might be confusing to developers, with the examples being noted in the RFC: https://wiki.php.net/rfc/is_literal#compiler_optimisations Thanks, Craig
