On Fri, 28 Feb 2020 at 16:25, Paul M. Jones <pmjo...@pmjones.io> wrote:
> Hi everyone, > > All outstanding issues on this RFC appear to be resolved one way or > another. With that in mind: > > Are there any members here who currently expect to vote "no", who have not > yet chimed in? I'd like to hear your criticisms and objections, so I can at > least attempt to resolve your concerns. > > I am especially interested to hear about technical or developer-experience > shortcomings, but of course variations on "this is better left to userland" > are understandable. > > Again, and as always, my thanks for your time and attention. > > > -- > Paul M. Jones > pmjo...@pmjones.io > http://paul-m-jones.com > > Modernizing Legacy Applications in PHP > https://leanpub.com/mlaphp > > Solving the N+1 Problem in PHP > https://leanpub.com/sn1php > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > Hello Paul, one question I do have here is about how PHP-PM process manager will be able to interact with this layer? Cause right now it does rewrite the $_SERVER variable for each incoming request for its child processes that handle the requests https://github.com/php-pm/php-pm/blob/a2872e13c3901401d5c2386a8ed62502db23d5f2/src/ProcessSlave.php#L463 It kind'a makes this not possible if there is no way to re-init the object. While read-only is, obviously, a good idea, there are some caveats like this that not only limit the possibilities but also what will the ServerRequest object even look like when $_SERVER is being rewritten like this? They relly on https://github.com/php-pm/php-pm-httpkernel package to handle the GET/POST/COOKIE/SESSION data for each supported framework trying to avoid the usage of the superglobals, but I see $_COOKIE being used. This, in turn, relies on https://github.com/guzzle/psr7/ and that one reads the data from the $_GET/$_POST/$_FILES the data: https://github.com/guzzle/psr7/blob/c8676a22904ebc3143b8485364cbe9ac97dc3f3e/src/ServerRequest.php#L170 Basically to put in in a single sentence - so far it seems that this RFC does not allow such usage at all and long-running processing has not been taken into account at all? Thanks! -- Arvīds Godjuks +371 26 851 664 arvids.godj...@gmail.com Skype: psihius Telegram: @psihius https://t.me/psihius
