On Thu, 27 May 2004, Andrei Zmievski wrote:
> On Thu, 27 May 2004, Sara Golemon wrote:
> > Nah, I know. I'm not saying I'm against it, all I'm saying is that noone
> > will hear any objections from me. It puts an extra tool in the hands of the
> > user at negligible cost and that's a good thing. All I meant by my comment
> > was that it's a tool I don't ever see myself (personally) using.
>
> So.. are we agreed that it won't do harm to PHP 5 at this point?
I don't mind, but it's up to the release master IMO.
Hi,
I saw it was already commited before I had a chance to respond. In any case, I think that the patch is quite harmless but I don't like the != NULL && !true logic. It's inconsistent with what is considered true/false in PHP today. I suggest either:
a) return true if you want the default handler to be called. I don't have a problem with this but people here say it's opposite from other frameworks. Are there really so many precedents?
b) return false (== IS_BOOL && value == 0). This gives a strict but reasonable interface and is still BC. I don't see a reason why people should be returning other false values besides "false".
Andi
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
