> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Dawid > Osuchowski > Sent: 14 January 2026 01:08 > To: [email protected] > Cc: [email protected]; Jakub Staniszewski > <[email protected]>; [email protected]; Dawid > Osuchowski <[email protected]>; Loktionov, Aleksandr > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net 2/2] ice: fix retry for AQ command > 0x06EE > > From: Jakub Staniszewski <[email protected]> > > Executing ethtool -m can fail reporting a netlink I/O error while firmware > link management holds the i2c bus used to communicate with the module. > > According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1] Section > 3.3.10.4 Read/Write SFF EEPROM (0x06EE) request should to be retried upon > receiving EBUSY from firmware. > > Commit e9c9692c8a81 ("ice: Reimplement module reads used by ethtool") > implemented it only for part of ice_get_module_eeprom(), leaving all other > calls to ice_aq_sff_eeprom() vulnerable to returning early on getting EBUSY > without retrying. > > Remove the retry loop from ice_get_module_eeprom() and add Admin Queue (AQ) command with opcode 0x06EE to the list of commands that should be retried on receiving EBUSY from firmware. > > Cc: [email protected] > Fixes: e9c9692c8a81 ("ice: Reimplement module reads used by ethtool") > Signed-off-by: Jakub Staniszewski <[email protected]> > Co-developed-by: Dawid Osuchowski <[email protected]> > Signed-off-by: Dawid Osuchowski <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Link: > https://www.intel.com/content/www/us/en/content-details/613875/intel-ethernet-controller-e810-datasheet.html > [1] > --- > drivers/net/ethernet/intel/ice/ice_common.c | 1 + > drivers/net/ethernet/intel/ice/ice_ethtool.c | 35 ++++++++------------ > 2 files changed, 15 insertions(+), 21 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
