> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Dawid > Osuchowski > Sent: 14 January 2026 01:08 > To: [email protected] > Cc: [email protected]; [email protected]; Loktionov, Aleksandr > <[email protected]>; Jakub Staniszewski > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Dawid Osuchowski > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net 1/2] ice: reintroduce retry > mechanism for indirect AQ > > From: Jakub Staniszewski <[email protected]> > > Add retry mechanism for indirect Admin Queue (AQ) commands. To do so we need > to keep the command buffer. > > This technically reverts commit 43a630e37e25 > ("ice: remove unused buffer copy code in ice_sq_send_cmd_retry()"), but > combines it with a fix in the logic by using a kmemdup() call, making it more > robust and less likely to break in the future due to programmer error. > > Cc: Michal Schmidt <[email protected]> > Cc: [email protected] > Fixes: 3056df93f7a8 ("ice: Re-send some AQ commands, as result of EBUSY AQ > error") > Signed-off-by: Jakub Staniszewski <[email protected]> > Co-developed-by: Dawid Osuchowski <[email protected]> > Signed-off-by: Dawid Osuchowski <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > --- > Ccing Michal, given they are the author of the "reverted" commit. > > drivers/net/ethernet/intel/ice/ice_common.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
