> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Przemek Kitszel > Sent: 18 June 2025 16:59 > To: [email protected]; Nguyen, Anthony L > <[email protected]> > Cc: [email protected]; Kitszel, Przemyslaw > <[email protected]>; Keller, Jacob E <[email protected]>; > Loktionov, Aleksandr <[email protected]>; Brandeburg, Jesse > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next] ice: convert ice_add_prof() to > bitmap > > From: Jesse Brandeburg <[email protected]> > > Previously the ice_add_prof() took an array of u8 and looped over it with > for_each_set_bit(), examining each 8 bit value as a bitmap. >This was just hard to understand and unnecessary, and was triggering undefined >behavior sanitizers with unaligned accesses within bitmap fields (on our >internal tools/builds). Since the @ptype being passed in was already declared >as a bitmap, refactor this to use native types with the advantage of >simplifying the code to use a single loop. > > Co-developed-by: Jacob Keller <[email protected]> > Signed-off-by: Jacob Keller <[email protected]> > Signed-off-by: Jesse Brandeburg <[email protected]> > Signed-off-by: Aleksandr Loktionov <[email protected]> > CC: Jesse Brandeburg <[email protected]> > Signed-off-by: Przemek Kitszel <[email protected]> > --- > .../net/ethernet/intel/ice/ice_flex_pipe.h | 7 +- > .../net/ethernet/intel/ice/ice_flex_pipe.c | 78 +++++++------------ > drivers/net/ethernet/intel/ice/ice_flow.c | 4 +- > 3 files changed, 34 insertions(+), 55 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
