On 6/18/25 13:54, Paul Menzel wrote:
Dear Przemek, dear Jesse,
Thank you for the patch.
Am 18.06.25 um 13:28 schrieb Przemek Kitszel:
From: Jesse Brandeburg <[email protected]>
Previously the ice_add_prof() took an array of u8 and looped over it with
for_each_set_bit(), examining each 8 bit value as a bitmap.
This was just hard to understand and unnecessary, and was triggering
undefined behavior sanitizers with unaligned accesses within bitmap
fields (on our internal tools/builds). Since the @ptype being passed in
was already declared as a bitmap, refactor this to use native types with
the advantage of simplifying the code to use a single loop.
Any tests to verify no regressions are introduced?
Hi, nothing specific, and nothing that could not be inferred from the
commit message, if our VAL would ask me, the reply would be: please test
against FDIR regressions :)
Alexandr has this patch included in a bigger pile of work, which passed
many tests, this is also a form we have present in our OOT driver for
about 3 years by now.
[...]
Reviewed-by: Paul Menzel <[email protected]>
Thank you!
Kind regards,
Paul
