> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of > Jacob Keller > Sent: Thursday, October 17, 2024 1:29 AM > To: Kolacinski, Karol <karol.kolacin...@intel.com>; intel-wired- > l...@lists.osuosl.org > Cc: net...@vger.kernel.org; Kubalewski, Arkadiusz > <arkadiusz.kubalew...@intel.com>; Nguyen, Anthony L > <anthony.l.ngu...@intel.com>; Kitszel, Przemyslaw > <przemyslaw.kits...@intel.com> > Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-net 4/4] ice: Add correct PHY > lane assignment > > > > On 10/10/2024 7:21 AM, Karol Kolacinski wrote: > > > /** > > * ice_ptp_init_phy_e825 - initialize PHY parameters > > * @hw: pointer to the HW struct > > @@ -2743,8 +2723,6 @@ static void ice_ptp_init_phy_e825(struct ice_hw > *hw) > > err = ice_read_phy_eth56g(hw, hw->pf_id, PHY_REG_REVISION, > &phy_rev); > > if (err || phy_rev != PHY_REVISION_ETH56G) > > ptp->phy_model = ICE_PHY_UNSUP; > > - > > - ptp->is_2x50g_muxed_topo = ice_is_muxed_topo(hw); > > } > > > Once we remove ptp->phy_model, this check for the PHY revision seems > like it is meaningless? > > Thanks, > Jake
Agree, to be removed in v3.
