On Wed, Jul 10, 2024 at 02:40:07PM -0600, Ahmed Zaki wrote: > From: Junfeng Guo <junfeng....@intel.com> > > Implement the core work of the runtime parser via: > - ice_parser_rt_execute() > - ice_parser_rt_reset() > - ice_parser_rt_pkt_buf_set() > > Reviewed-by: Marcin Szycik <marcin.szy...@linux.intel.com> > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> > Signed-off-by: Junfeng Guo <junfeng....@intel.com> > Signed-off-by: Ahmed Zaki <ahmed.z...@intel.com>
> diff --git a/drivers/net/ethernet/intel/ice/ice_parser_rt.c > b/drivers/net/ethernet/intel/ice/ice_parser_rt.c ... > +static u16 ice_ptype_resolve(struct ice_parser_rt *rt) > +{ > + struct ice_parser *psr = rt->psr; > + struct ice_ptype_mk_tcam_item *item; nit: Please consider arranging these variables in reverse xmas tree order. Flagged by https://github.com/ecree-solarflare/xmastree > + > + item = ice_ptype_mk_tcam_match(psr->ptype_mk_tcam_table, > + rt->markers, ICE_MARKER_ID_SIZE); > + if (item) > + return item->ptype; > + > + ice_debug(rt->psr->hw, ICE_DBG_PARSER, "Could not resolve PTYPE\n"); > + return U16_MAX; > +} ...