> On Mar 28, 2024, at 2:16 PM, Tony Nguyen <anthony.l.ngu...@intel.com> wrote: > >> +/* Intel(R) Ethernet Controller E830-CC for SFP-DD */ >> +#define ICE_DEV_ID_E83CC0_SFP_DD 0x12D4 > > This doesn't compile; there's a stray '0' here.
Not stray, just mispositioned in the definition above. > ../drivers/net/ethernet/intel/ice/ice_common.c:166:14: error: > ‘ICE_DEV_ID_E830CC_SFP_DD’ undeclared (first use in this function); did you > mean ‘ICE_DEV_ID_E83CC0_SFP_DD’? > 166 | case ICE_DEV_ID_E830CC_SFP_DD: > | ^~~~~~~~~~~~~~~~~~~~~~~~ > | ICE_DEV_ID_E83CC0_SFP_DD > > ... -- Mark Rustad (he/him), Ethernet Products Group, Intel Corporation