On 3/26/2024 9:36 AM, Paul Greenwalt wrote:
Update existing E830 device ids and comments to align with new naming 'C'
for 100G and 'CC' for 200G.

Reviewed-by: Wojciech Drewek <wojciech.dre...@intel.com>
Signed-off-by: Paul Greenwalt <paul.greenw...@intel.com>
---

...

diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h 
b/drivers/net/ethernet/intel/ice/ice_devids.h
index c37b2b450b02..9a1bc434f167 100644
--- a/drivers/net/ethernet/intel/ice/ice_devids.h
+++ b/drivers/net/ethernet/intel/ice/ice_devids.h
@@ -16,14 +16,14 @@
  #define ICE_DEV_ID_E823L_1GBE         0x124F
  /* Intel(R) Ethernet Connection E823-L for QSFP */
  #define ICE_DEV_ID_E823L_QSFP         0x151D
-/* Intel(R) Ethernet Controller E830-C for backplane */
-#define ICE_DEV_ID_E830_BACKPLANE      0x12D1
-/* Intel(R) Ethernet Controller E830-C for QSFP */
-#define ICE_DEV_ID_E830_QSFP56         0x12D2
-/* Intel(R) Ethernet Controller E830-C for SFP */
-#define ICE_DEV_ID_E830_SFP            0x12D3
-/* Intel(R) Ethernet Controller E830-C for SFP-DD */
-#define ICE_DEV_ID_E830_SFP_DD         0x12D4
+/* Intel(R) Ethernet Controller E830-CC for backplane */
+#define ICE_DEV_ID_E830CC_BACKPLANE    0x12D1
+/* Intel(R) Ethernet Controller E830-CC for QSFP */
+#define ICE_DEV_ID_E830CC_QSFP56       0x12D2
+/* Intel(R) Ethernet Controller E830-CC for SFP */
+#define ICE_DEV_ID_E830CC_SFP          0x12D3
+/* Intel(R) Ethernet Controller E830-CC for SFP-DD */
+#define ICE_DEV_ID_E83CC0_SFP_DD       0x12D4

This doesn't compile; there's a stray '0' here.

../drivers/net/ethernet/intel/ice/ice_common.c:166:14: error: ‘ICE_DEV_ID_E830CC_SFP_DD’ undeclared (first use in this function); did you mean ‘ICE_DEV_ID_E83CC0_SFP_DD’?
  166 |         case ICE_DEV_ID_E830CC_SFP_DD:
      |              ^~~~~~~~~~~~~~~~~~~~~~~~
      |              ICE_DEV_ID_E83CC0_SFP_DD

        ...

  /* Intel(R) Ethernet Controller E830-C for backplane */
  #define ICE_DEV_ID_E830C_BACKPLANE    0x12D5
  /* Intel(R) Ethernet Controller E830-C for QSFP */

Reply via email to