> -----Original Message-----
> From: Alan Brady <alan.br...@intel.com>
> Sent: Wednesday, February 7, 2024 4:43 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Tantilov, Emil S <emil.s.tanti...@intel.com>;
> Brandeburg, Jesse <jesse.brandeb...@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kits...@intel.com>; Brady, Alan <alan.br...@intel.com>
> Subject: [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for
> marker packets
>
> From: Emil Tantilov <emil.s.tanti...@intel.com>
>
> Fix softirq's not being handled during napi_schedule() call when
> receiving marker packets for queue disable by disabling local bottom
> half.
>
> The issue can be seen on ifdown:
> NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
>
> Using ftrace to catch the failing scenario:
> ifconfig [003] d.... 22739.830624: softirq_raise: vec=3 [action=NET_RX]
> <idle>-0 [003] ..s.. 22739.831357: softirq_entry: vec=3 [action=NET_RX]
>
> No interrupt and CPU is idle.
>
> After the patch, with BH locks:
> ifconfig [003] d.... 22993.928336: softirq_raise: vec=3 [action=NET_RX]
> ifconfig [003] ..s1. 22993.928337: softirq_entry: vec=3 [action=NET_RX]
>
> Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support")
> Reviewed-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com>
> Signed-off-by: Emil Tantilov <emil.s.tanti...@intel.com>
> Signed-off-by: Alan Brady <alan.br...@intel.com>
> ---
> drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> index d0cdd63b3d5b..390977a76de2 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
Tested-by: Krishneil Singh <krishneil.k.si...@intel.com>
