> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Jesse > Brandeburg > Sent: Wednesday, December 6, 2023 6:31 AM > To: intel-wired-...@lists.osuosl.org > Cc: Kitszel, Przemyslaw <przemyslaw.kits...@intel.com>; Brandeburg, Jesse > <jesse.brandeb...@intel.com>; Julia Lawall <julia.law...@inria.fr>; Lobakin, > Aleksander <aleksander.loba...@intel.com>; marcin.szy...@linux.intel.com; > ho...@kernel.org; net...@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH iwl-next v2 04/15] i40e: field prep > conversion > > Refactor i40e driver to use FIELD_PREP(), which reduces lines of code > and adds clarity of intent. > > This code was generated by the following coccinelle/spatch script and > then manually repaired. > > Refactor one function with multiple if's to return quickly to make lines > fit in 80 columns. > > @prep2@ > constant shift,mask; > type T; > expression a; > @@ > -(((T)(a) << shift) & mask) > +FIELD_PREP(mask, a) > > @prep@ > constant shift,mask; > type T; > expression a; > @@ > -((T)((a) << shift) & mask) > +FIELD_PREP(mask, a) > > Cc: Julia Lawall <julia.law...@inria.fr> > Reviewed-by: Marcin Szycik <marcin.szy...@linux.intel.com> > Reviewed-by: Simon Horman <ho...@kernel.org> > Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com> > --- > v2: updated commit message > --- > drivers/net/ethernet/intel/i40e/i40e_common.c | 83 ++++++------- > drivers/net/ethernet/intel/i40e/i40e_dcb.c | 116 ++++++++---------- > drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +- > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 41 +++---- > .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 8 +- > 5 files changed, 109 insertions(+), 151 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A Contingent worker at Intel) _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
