> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Jesse > Brandeburg > Sent: Wednesday, December 6, 2023 6:31 AM > To: intel-wired-...@lists.osuosl.org > Cc: Kitszel, Przemyslaw <przemyslaw.kits...@intel.com>; Brandeburg, Jesse > <jesse.brandeb...@intel.com>; Lobakin, Aleksander > <aleksander.loba...@intel.com>; marcin.szy...@linux.intel.com; > ho...@kernel.org; net...@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH iwl-next v2 07/15] ice: fix pre-shifted bit > usage > > While converting to FIELD_PREP() and FIELD_GET(), it was noticed that > some of the RSS defines had *included* the shift in their definitions. > This is completely outside of normal, such that a developer could easily > make a mistake and shift at the usage site (like when using > FIELD_PREP()). > > Rename the defines and set them to the "pre-shifted values" so they > match the template the driver normally uses for masks and the member > bits of the mask, which also allows the driver to use FIELD_PREP > correctly with these values. Use GENMASK() for this changed MASK value. > > Do the same for the VLAN EMODE defines as well. > > Reviewed-by: Marcin Szycik <marcin.szy...@linux.intel.com> > Reviewed-by: Simon Horman <ho...@kernel.org> > Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com> > --- > v2: no change > --- > .../net/ethernet/intel/ice/ice_adminq_cmd.h | 18 +++++++++--------- > drivers/net/ethernet/intel/ice/ice_lib.c | 7 ++++--- > drivers/net/ethernet/intel/ice/ice_virtchnl.c | 10 +++++----- > .../net/ethernet/intel/ice/ice_vsi_vlan_lib.c | 16 +++++++++++----- > 4 files changed, 29 insertions(+), 22 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A Contingent worker at Intel) _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
