On Thu, Jul 21, 2016 at 04:07:59PM +0300, Joonas Lahtinen wrote: > On ke, 2016-07-20 at 14:12 +0100, Chris Wilson wrote: > > - trace_i915_gem_ring_sync_to(*to_req, from, from_req); > > - ret = to->semaphore.sync_to(*to_req, from, seqno); > > + trace_i915_gem_ring_sync_to(to, from); > > Will somebody go nuts for changing the tracing just like so? I remember > somebody treating it somewhat of an ABI.
They do, but they shouldn't! The format is discoverable though the tracing interface It's a moot point here as the trace output is unchanged, just the trace point call simplified to match the parent. > > @@ -1636,7 +1635,6 @@ i915_gem_do_execbuffer(struct drm_device *dev, void > > *data, > > params->dispatch_flags = dispatch_flags; > > params->batch_obj = batch_obj; > > params->ctx = ctx; > > - params->request = req; > > Not sure why you especially want to always use params->request form? Stack deduplication. It'll be clearer eventually. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
