Instead of setting vrr.guardband to vblank, use optimal guardband that works for most of the cases. This will help in avoiding need of change in guardband and fix the LRR feature that needs seamless switching to a lower refresh rate.
First few patches fix/refactor and extract common functions required for dsc/scaler prefill time computation. Later patches use these helpers to compute an optimized guardband. Also, for seamless_mn where vtotal is same but mode clock is changed to seamlessly switch to lower rate, re-compute the vrr timings. Few things that still need work: -The timestamps corresponding with next start of vactive still need to be fixed with the new scheme. -Re-enabling CMRR Rev2: -Address comments from Mitul. -Extract helpers for dsc/scaler prefill latencies. -Fix downscaling factor for chroma subsampling. -Use missing pkg C max latency. -Fix guardband computation for seamless mn, always use vblank for higher resolution. Rev3: -Drop patches for computing and storing PSR/Panel Replay wake times latencies and use existing helpers to compute these in intel_alpm.c. -Drop patch to change the Vmin as it was not required. Rev4: -Rebase -Drop patch for checking bounds for scaler array access. -Use a new flag for setting vrr timings for seamless drrs. Rev5: -Address comments from Mitul, Jani: -Refactor few helpers for computing latencies. -Rename the helper to check the guardband to intel_crtc_guardband_atomic_check() -Refactor the helper intel_panel_highest_mode(). Rev6: -Rebase -Address review comments from Mitul. -Improve documentation for and other minor fixes in Patch#12 Ankit Nautiyal (12): drm/i915/skl_watermark: Fix the scaling factor for chroma subsampling drm/i915/skl_watermark: Pass linetime as argument to latency helpers drm/i915/skl_scaler: Introduce helper for chroma downscale factor drm/i915/display: Extract helpers to set dsc/scaler prefill latencies drm/i915/dp: Add SDP latency computation helper drm/i915/alpm: Add function to compute max link-wake latency drm/i915/vrr: Use vrr.sync_start for getting vtotal drm/i915/display: Add guardband check for feature latencies drm/i915/skl_watermark: Remove redundant latency checks from vblank validation drm/i915/vrr: Use static guardband to support seamless LRR switching drm/i915/panel: Refactor helper to get highest fixed mode drm/i915/vrr: Fix seamless_mn drrs for PTL drivers/gpu/drm/i915/display/intel_alpm.c | 15 ++ drivers/gpu/drm/i915/display/intel_alpm.h | 2 + drivers/gpu/drm/i915/display/intel_display.c | 178 ++++++++++++- drivers/gpu/drm/i915/display/intel_display.h | 8 + .../drm/i915/display/intel_display_types.h | 2 + drivers/gpu/drm/i915/display/intel_dp.c | 63 ++++- drivers/gpu/drm/i915/display/intel_dp.h | 2 + drivers/gpu/drm/i915/display/intel_panel.c | 11 +- drivers/gpu/drm/i915/display/intel_panel.h | 3 +- drivers/gpu/drm/i915/display/intel_vrr.c | 243 ++++++++++++++++-- drivers/gpu/drm/i915/display/intel_vrr.h | 3 +- drivers/gpu/drm/i915/display/skl_scaler.c | 5 + drivers/gpu/drm/i915/display/skl_scaler.h | 3 + drivers/gpu/drm/i915/display/skl_watermark.c | 89 +------ drivers/gpu/drm/i915/display/skl_watermark.h | 1 + 15 files changed, 508 insertions(+), 120 deletions(-) -- 2.45.2