On Tue, 2025-02-18 at 23:18 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrj...@linux.intel.com>
> 
> Reuse intel_plane_set_invisible() in intel_plane_disable_noatomic()
> instead of hand rolling the same stuff.
> 
> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Vinod Govindapillai <vinod.govindapil...@intel.com>

> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 75b184c933e7..9756f52184c0 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -674,13 +674,9 @@ void intel_plane_disable_noatomic(struct intel_crtc 
> *crtc,
>                   plane->base.base.id, plane->base.name,
>                   crtc->base.base.id, crtc->base.name);
>  
> +     intel_plane_set_invisible(crtc_state, plane_state);
>       intel_set_plane_visible(crtc_state, plane_state, false);
>       intel_plane_fixup_bitmasks(crtc_state);
> -     crtc_state->data_rate[plane->id] = 0;
> -     crtc_state->data_rate_y[plane->id] = 0;
> -     crtc_state->rel_data_rate[plane->id] = 0;
> -     crtc_state->rel_data_rate_y[plane->id] = 0;
> -     crtc_state->min_cdclk[plane->id] = 0;
>  
>       if ((crtc_state->active_planes & ~BIT(PLANE_CURSOR)) == 0 &&
>           hsw_ips_disable(crtc_state)) {

Reply via email to