RE: [PATCH 6/6] drm/i915/wm: Club the initialized variables together

[Golani, Mitulkumar Ajitkumar]

> -----Original Message-----
> From: Kandpal, Suraj <suraj.kand...@intel.com>
> Sent: 03 December 2024 14:17
> To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> Cc: Golani, Mitulkumar Ajitkumar <mitulkumar.ajitkumar.gol...@intel.com>;
> Kandpal, Suraj <suraj.kand...@intel.com>
> Subject: [PATCH 6/6] drm/i915/wm: Club the initialized variables together
> 
> Refactor program_dpkgc function so that all initialized variables are clubbed
> together.
> 
> Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/skl_watermark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> b/drivers/gpu/drm/i915/display/skl_watermark.c
> index 4c032b1758e7..d93f6786db0e 100644
> --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> @@ -2862,9 +2862,9 @@ intel_program_dpkgc_latency(struct
> intel_atomic_state *state)
>       struct intel_crtc *crtc;
>       struct intel_crtc_state *new_crtc_state;
>       u32 latency = LNL_PKG_C_LATENCY_MASK;
> +     u32 added_wake_time = 0;
>       u32 max_linetime = 0;
>       u32 clear, val;
> -     u32 added_wake_time = 0;
>       bool fixed_refresh_rate = false;

If go by commit message words, change does not actually club all initialised 
params together and uninitialized separate.

>       int i;
> 
> --
> 2.34.1