RE: [PATCH 3/6] drm/i915/wm: Rename enable_dpkgc variable

[Golani, Mitulkumar Ajitkumar]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Suraj
> Kandpal
> Sent: 15 November 2024 21:31
> To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> Cc: Govindapillai, Vinod <vinod.govindapil...@intel.com>; Nikula, Jani
> <jani.nik...@intel.com>; Kandpal, Suraj <suraj.kand...@intel.com>
> Subject: [PATCH 3/6] drm/i915/wm: Rename enable_dpkgc variable
> 
> Rename the enable_dpkgc variable to make it more clear what it represents
> which is that if we are in fixed refresh rate or not.

Changing names for the sake to this function doesn't make any sense to me here, 
 can be dropped if not required. 
> 
> Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/skl_watermark.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> b/drivers/gpu/drm/i915/display/skl_watermark.c
> index 6d5f64ed52ed..9ce3b5580df4 100644
> --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> @@ -2855,7 +2855,8 @@ static int skl_wm_add_affected_planes(struct
> intel_atomic_state *state,
>   * Program PKG_C_LATENCY Added Wake Time = 0
>   */
>  static void
> -skl_program_dpkgc_latency(struct drm_i915_private *i915, bool
> enable_dpkgc)
> +skl_program_dpkgc_latency(struct drm_i915_private *i915,
> +                       bool fixed_refresh_rate)
>  {
>       u32 max_latency = LNL_PKG_C_LATENCY_MASK, added_wake_time =
> 0;
>       u32 clear, val;
> @@ -2863,7 +2864,7 @@ skl_program_dpkgc_latency(struct
> drm_i915_private *i915, bool enable_dpkgc)
>       if (DISPLAY_VER(i915) < 20)
>               return;
> 
> -     if (enable_dpkgc) {
> +     if (fixed_refresh_rate) {
>               max_latency = skl_watermark_max_latency(i915, 1);
>               if (max_latency == 0)
>                       max_latency = LNL_PKG_C_LATENCY_MASK;
> --
> 2.34.1