Re: [Intel-gfx] [PATCH 09/13] drm/i915/mtl: Define mask for DDI AUX interrupts

[Radhakrishna Sripada]

On Thu, Apr 20, 2023 at 03:40:46PM +0300, Mika Kahola wrote:
> From: Gustavo Sousa <gustavo.so...@intel.com>
> 
> Xe_LPD+ defines interrupt bits for only DDI ports in the DE Port
> Interrupt registers. The bits for Type-C ports are defined in the PICA
> interrupt registers.
> 
> BSpec: 50064
> Signed-off-by: Gustavo Sousa <gustavo.so...@intel.com>
Missing S-o-b, with that,
Reviewed-by: Radhakrishna Sripada <radhakrishna.srip...@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 2b94b8ca8ec9..e5f12aa141f6 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1938,7 +1938,10 @@ static u32 gen8_de_port_aux_mask(struct 
> drm_i915_private *dev_priv)
>  {
>       u32 mask;
>  
> -     if (DISPLAY_VER(dev_priv) >= 13)
> +     if (DISPLAY_VER(dev_priv) >= 14)
> +             return TGL_DE_PORT_AUX_DDIA |
> +                     TGL_DE_PORT_AUX_DDIB;
> +     else if (DISPLAY_VER(dev_priv) >= 13)
>               return TGL_DE_PORT_AUX_DDIA |
>                       TGL_DE_PORT_AUX_DDIB |
>                       TGL_DE_PORT_AUX_DDIC |
> -- 
> 2.34.1
>