Chris Wilson <ch...@chris-wilson.co.uk> writes: > When we look at i915_request_is_started() we must be careful in case we > are using a request that does not have the initial-breadcrumb and > instead the is-started is being compared against the end of the previous > request. This will make wait_for_submit() declare that a request has > been already submitted too early.
submitted....started...handled_by_gpu. I guess wait_for_submit is generic enough to cater all cases but we actually do not wait for submit but we wait for gpu to reach it. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Mika Kuoppala <mika.kuopp...@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c > b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index b71f04db9c6e..f6949cd55e92 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -75,7 +75,7 @@ static bool is_active(struct i915_request *rq) > if (i915_request_on_hold(rq)) > return true; > > - if (i915_request_started(rq)) > + if (i915_request_has_initial_breadcrumb(rq) && i915_request_started(rq)) > return true; > > return false; > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
