Re: [Intel-gfx] [PATCH 03/12 v2] drm/i915: move vbetool invoked ier stuff

[Daniel Vetter]

On Thu, Apr 26, 2012 at 04:03:00PM -0700, Ben Widawsky wrote:
> This extra bit of interrupt enabling code doesn't belong in the wait
> seqno function. If anything we should pull it out to a helper so the
> throttle code can also use it. The history is a bit vague, but I am
> going to attempt to just dump it, unless someone can argue otherwise.
> 
> Removing this allows for a shared lock free wait seqno function. To keep
> tabs on this issue though, the IER value is stored on error capture
> (recommended by Chris Wilson)
> 
> v2: fixed typo EIR->IER (Ben)
> Fix some white space (Ben)
> Move IER capture to globally instead of per ring (Ben)
> 
> Signed-off-by: Ben Widawsky <b...@bwidawsk.net>
Queued for -next with the small addition that ier is a 16bit reg on gen2,
thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx