On Thu, Jan 26, 2012 at 01:42:02PM +0000, Chris Wilson wrote:
> On Thu, 26 Jan 2012 11:41:11 +0100, Daniel Vetter <daniel.vet...@ffwll.ch>
> wrote:
> > The locking in our setup and teardown paths is rather arbitrary, but
> > generally we try to protect gem stuff with dev->struct_mutex. Further,
> > the ums/gem ioctl to setup gem _does_ take the look. So fix up this
> > benign inconsistency.
>
> It is completely arbitrary and only exists to keep lockdep and various
> BUG_ON(mutex_lock) happy. From your reading, we would have a lockdep
> warning with ums/gem?
>
> The extra little step towards consistency is likely to save a warning
> later, so
> Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk>
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
