On Wed, 22 Jun 2011 10:07:50 -0700, Ben Widawsky <bwida...@gmail.com> wrote: > On Wed, Jun 22, 2011 at 10:00 AM, Chris Wilson > <ch...@chris-wilson.co.uk>wrote: > > > On Wed, 22 Jun 2011 09:55:00 -0700, Ben Widawsky <b...@bwidawsk.net> wrote: > > > Get some more useful info for debugging backtraces on forcewake > > > problems. Appropriate debug flags will be required for the drm module. > > > > Wouldn't it be neater to pass the reg down to > > gen6_gt_force_wake_get() so that we only have a single debug message and > > not an additional one for every inlined read/write? > > -Chris > > > > Urg... having some trouble with my email right now, so you have to deal with > my gmail/webmail... > > 1. Yes, but I was lazy. > 2. People call force_wake_get() without actually specifying a register, so I > didn't want to enforce people entering bogus info on those calls.
We could always go for the traditional file:line automagic macros... But we already have that from the stacktrace if people are good enough to provide symbols. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
