On Thu, 14 Apr 2011 10:03:41 +0100, Chris Wilson <ch...@chris-wilson.co.uk> 
wrote:

> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5360,7 +5360,7 @@ static int intel_crtc_cursor_set(struct drm_crtc *crtc,
>                       goto fail_locked;
>               }
>  
> -             ret = i915_gem_object_set_to_gtt_domain(obj, 0);
> +             ret = i915_gem_object_set_to_display_plane(obj, NULL);
>               if (ret) {
>                       DRM_ERROR("failed to move cursor bo into the GTT\n");
>                       goto fail_unpin;
> diff --git a/drivers/gpu/drm/i915/intel_overlay.c 
> b/drivers/gpu/drm/i915/intel_overlay.c
> index a670c00..e0903c5 100644
> --- a/drivers/gpu/drm/i915/intel_overlay.c
> +++ b/drivers/gpu/drm/i915/intel_overlay.c
> @@ -777,7 +777,7 @@ static int intel_overlay_do_put_image(struct 
> intel_overlay *overlay,
>       if (ret != 0)
>               return ret;
>  
> -     ret = i915_gem_object_set_to_gtt_domain(new_bo, 0);
> +     ret = i915_gem_object_set_to_display_plane(new_bo, NULL);

set_to_display_plane has a comment stating that it is always called from
a non - interruptible context and uses a non-interruptible flush wait as
a result.

I think we would want these new code paths to allow for interrupting the
operation?

-- 
keith.pack...@intel.com

Attachment: pgprlfmVfc54N.pgp
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to