Re: [Intel-gfx] [ANNOUNCE] xf86-video-intel 2.11.901

[Chris Wilson]

On Wed, 16 Jun 2010 00:05:34 +0200, Clemens Eisserer <linuxhi...@gmail.com> 
wrote:
> Hi Chris,
> 
> >  $ git checkout 2.11.901
> >  $ git revert f74b3f82
> Ah thanks, didn't know the checkout thing.
> 
> Hmm, if I revert that commit it no longer builds:
>   CC     i915_render.lo
> i915_render.c: In function ‘i915_prepare_composite’:
> i915_render.c:836: error: ‘intel_screen_private’ has no member named
> ‘render_current_dest’

Argh. It has the vital half of the centre sampling fix mixed in.

This hack should be sufficient to force the target buffer to be updated 
everytime.

diff --git a/src/i915_render.c b/src/i915_render.c
index 8870019..3505083 100644
--- a/src/i915_render.c
+++ b/src/i915_render.c
@@ -1435,7 +1435,7 @@ static void i915_emit_composite_setup(ScrnInfoPtr scrn)
        intel->last_3d = LAST_3D_RENDER;
 
        /* BUF_INFO is an implicit flush, so avoid if the target has not 
changed */
-       if (dest != intel->render_current_dest) {
+       if (1 || dest != intel->render_current_dest) {
                uint32_t tiling_bits;
 
                tiling_bits = 0;

That does indeed seem to have an effect on KDE -- can you confirm if it
fixes the rendering corruption and if there remains any?
Now to understand why.

Thanks,
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx