Sounds great. Thank you.
> -----Original Message----- > From: [email protected] <[email protected]> > Sent: Donnerstag, 27. Juni 2019 23:16 > To: Langer, Christoph <[email protected]>; i18n- > [email protected]; core-libs-dev <[email protected]> > Subject: Re: <i18n dev> [13] RFR: 8226876: Assertion in > sun/util/locale/provider/CalendarDataUtility on Windows after JDK-8218960 > > Thanks for the review, Christoph. > > I'll wait for a whole day so that everyone sees the fix. Planning to > push it tomorrow. > > Naoto > > On 6/27/19 2:05 PM, Langer, Christoph wrote: > >>> The change looks good to me. But I would say the assertion in > >> CalendarDataUtility in line 266 is pointless now, isn't it? > >> > >> Yes, but would not hurt leaving it. It would catch error if yet another > >> case is installed (and it forgot to provide a default value) in the > >> switch statement. So I just left it. > > > > Ok, sounds reasonable. > > > > What's your target for pushing this? I'd like to backport it to OpenJDK > > 11.0.4 > to fix the regression there... > > > > /Christoph > >
