On 6/27/19 1:52 PM, Langer, Christoph wrote:
Hi Naoto,
thanks for providing a fix so quickly.
The change looks good to me. But I would say the assertion in
CalendarDataUtility in line 266 is pointless now, isn't it?
Yes, but would not hurt leaving it. It would catch error if yet another
case is installed (and it forgot to provide a default value) in the
switch statement. So I just left it.
Naoto
Best regards
Christoph
-----Original Message-----
From: i18n-dev <i18n-dev-boun...@openjdk.java.net> On Behalf Of
naoto.s...@oracle.com
Sent: Donnerstag, 27. Juni 2019 22:22
To: i18n-dev@openjdk.java.net; core-libs-dev <core-libs-
d...@openjdk.java.net>
Subject: <i18n dev> [13] RFR: 8226876: Assertion in
sun/util/locale/provider/CalendarDataUtility on Windows after JDK-8218960
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8226876
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8226876/webrev.00/
This is an issue discovered on fixing a test case refactoring. [1] The
fix is to simply provide the default values to the first-day-of-week and
minimal-days-in-first-week, if the underlying providers cannot provide them.
Naoto
[1] https://mail.openjdk.java.net/pipermail/i18n-dev/2019-
June/002868.html
