Hi Nakamura-san,
Thanks for fixing this. Since it is using a heuristic way to detect
"unknown", I'd use String.endsWith() instead of String.contains() both
in HostLocaleProviderAdapterImpl.java and LocaleProviders.java, which
would be more accurate.
Naoto
On 3/7/19 10:25 PM, Toshio 5 Nakamura wrote:
Hi,
Could you review this fix? I'd like to have a sponsor of it, since I'm an
author.
Bug: https://bugs.openjdk.java.net/browse/JDK-8220227
Webrev: http://cr.openjdk.java.net/~tnakamura/8220227/webrev.00/
Issue:
Under Windows 10 non-English, Locale.getDisplayCountry() shows an error
message,
if Host Locale Provider is used (-Djava.locale.providers=HOST).
Fix proposal:
The current code compares "Unknown Region (" with the result, but it could
be translated.
I believe we can compare it with "("+RegionCode+")", which covers all 38
Language
Packs of Windows Server 2016.
Thanks,
Toshio Nakamura
